Re: [PATCH bpf-next] libbpf: fix negative FD close() in xsk_setup_xdp_prog()

[Daniel Borkmann <daniel@xxxxxxxxxxxxx>]

On 11/7/19 6:40 AM, Andrii Nakryiko wrote:
> Fix issue reported by static analysis (Coverity). If bpf_prog_get_fd_by_id()
> fails, xsk_lookup_bpf_maps() will fail as well and clean-up code will attempt
> close() with fd=-1. Fix by checking bpf_prog_get_fd_by_id() return result and
> exiting early.
>
> Fixes: 10a13bb40e54 ("libbpf: remove qidconf and better support external bpf programs.")
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>

Applied, thanks!