On Mon, Oct 21, 2019 at 12:01 PM Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> wrote: > > On Mon, Oct 21, 2019 at 06:57 PM CEST, Andrii Nakryiko wrote: > > LIBBPF_OPTS is implemented as a mix of field declaration and memset > > + assignment. This makes it neither variable declaration nor purely > > statements, which is a problem, because you can't mix it with either > > other variable declarations nor other function statements, because C90 > > compiler mode emits warning on mixing all that together. > > > > This patch changes LIBBPF_OPTS into a strictly declaration of variable > > and solves this problem, as can be seen in case of bpftool, which > > previously would emit compiler warning, if done this way (LIBBPF_OPTS as > > part of function variables declaration block). > > > > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > > --- > > Just a suggestion - macro helpers like this usually have DECLARE in > their name. At least in the kernel. For instance DECLARE_COMPLETION. Yes, it makes sense. This will cause some extra code churn, but it's not too late. Will rename in v2 and fix current usages. > > -Jakub
