Re: [PATCH bpf-next v2] scripts/bpf: Print an error when known types list needs updating

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 20, 2019 at 4:24 AM Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> wrote:
>
> Don't generate a broken bpf_helper_defs.h header if the helper script needs
> updating because it doesn't recognize a newly added type. Instead print an
> error that explains why the build is failing, clean up the partially
> generated header and stop.
>
> v1->v2:
> - Switched from temporary file to .DELETE_ON_ERROR.
>
> Fixes: 456a513bb5d4 ("scripts/bpf: Emit an #error directive known types list needs updating")
> Suggested-by: Andrii Nakryiko <andriin@xxxxxx>
> Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> ---

LGTM, thanks!

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

>  scripts/bpf_helpers_doc.py | 4 ++--
>  tools/lib/bpf/Makefile     | 3 +++
>  2 files changed, 5 insertions(+), 2 deletions(-)
>

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux