On Fri, Oct 18, 2019 at 11:18:48AM +0800, Kefeng Wang wrote: > For kernel logging macro, pr_warning is completely removed and > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry > to kernel logging macro, then we could drop pr_warning in the > whole linux code. > > Cc: Alexei Starovoitov <ast@xxxxxxxxxx> > Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx> > Cc: Martin KaFai Lau <kafai@xxxxxx> > Cc: Song Liu <songliubraving@xxxxxx> > Cc: Yonghong Song <yhs@xxxxxx> > Cc: bpf@xxxxxxxxxxxxxxx > Acked-by: Andrii Nakryiko <andriin@xxxxxx> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> > Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> > --- > tools/lib/bpf/btf.c | 56 +-- > tools/lib/bpf/btf_dump.c | 18 +- > tools/lib/bpf/libbpf.c | 679 ++++++++++++++++---------------- > tools/lib/bpf/libbpf_internal.h | 8 +- > tools/lib/bpf/xsk.c | 4 +- > 5 files changed, 379 insertions(+), 386 deletions(-) Nack. I prefer this type of renaming to go via bpf tree. It's not a kernel patch. It's touching user space library which is under heavy development. Doing any other way will cause a ton of conflicts.
