On Sun, Oct 6, 2019 at 10:29 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Sun, Oct 6, 2019 at 8:31 PM Andrii Nakryiko <andriin@xxxxxx> wrote:
> >
> > Current Makefile dependency chain is not strict enough and allows
> > test_attach_probe.o to be built before test_progs's
> > prog_test/attach_probe.o is built, which leads to assembler compainig
> > about missing included binary.
> >
> > This patch is a minimal fix to fix this issue by enforcing that
> > test_attach_probe.o (BPF object file) is built before
> > prog_tests/attach_probe.c is attempted to be compiled.
> >
> > Fixes: 928ca75e59d7 ("selftests/bpf: switch tests to new bpf_object__open_{file, mem}() APIs")
> > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
>
> It doesn't help.
> Before and after I still see:
> $ cd selftests/bpf/
> $ make
> ...
> /tmp/cco8plDk.s: Assembler messages:
> /tmp/cco8plDk.s:8: Error: file not found: test_attach_probe.o
:( I'll try to come up with better fix then. Thanks for checking.
