On Sun, Oct 6, 2019 at 5:32 PM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Sun, Oct 6, 2019 at 5:13 PM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > On Sun, Oct 6, 2019 at 4:56 PM Alexei Starovoitov > > <alexei.starovoitov@xxxxxxxxx> wrote: > > > > > > On Sat, Oct 5, 2019 at 10:46 PM Andrii Nakryiko <andriin@xxxxxx> wrote: > > > > > > > > Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > > > > auto-generate it into bpf_helpers_defs.h, which is now included from > > > > bpf_helpers.h. > > > > > > > > Suggested-by: Alexei Starovoitov <ast@xxxxxx> > > > > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > > > > --- > > > > tools/lib/bpf/.gitignore | 1 + > > > > tools/lib/bpf/Makefile | 10 +- > > > > tools/lib/bpf/bpf_helpers.h | 264 +----------------------------------- > > > > 3 files changed, 10 insertions(+), 265 deletions(-) > > > > > > This patch doesn't apply to bpf-next. > > > > Yes, it has to be applied on top of bpf_helpers.h move patch set. I > > can bundle them together and re-submit as one patch set, but I don't > > think there were any remaining issues besides the one solved in this > > patch set (independence from any specific bpf.h UAPI), so that one can > > be applied as is. > > It looks to me that auto-gen of bpf helpers set is ready, > whereas move is till being debated. > I also would like to test autogen-ed .h in my environment first > before we move things around. Alright, will post v4 based on master with bpf_helpers.h still in selftests/bpf
