On Tue, Oct 1, 2019 at 12:10 AM Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > > > +struct bpf_map_def { > > + unsigned int type; > > + unsigned int key_size; > > + unsigned int value_size; > > + unsigned int max_entries; > > + unsigned int map_flags; > > + unsigned int inner_map_idx; > > + unsigned int numa_node; > > +}; > > Didn't we agree on no new bpf_map_def ABI in libbpf, and that all > additions should be BTF-based? Oh yes, we did, sorry, this is an oversight. I really appreciate you pointing this out ;) I'll go over bpf_helpers.h carefully and will double-check if we don't have any other custom selftests-only stuff left there. > > -Toke >