> On Sep 30, 2019, at 4:36 PM, Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote: > > On Mon, 30 Sep 2019 23:25:33 +0000, Song Liu wrote: >>> On Sep 30, 2019, at 4:18 PM, Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote: >>> >>> On Mon, 30 Sep 2019 15:58:35 -0700, Andrii Nakryiko wrote: >>>> On Mon, Sep 30, 2019 at 3:55 PM Song Liu <liu.song.a23@xxxxxxxxx> wrote: >>>>> >>>>> On Mon, Sep 30, 2019 at 1:43 PM Andrii Nakryiko <andriin@xxxxxx> wrote: >>>>>> >>>>>> Make bpf_helpers.h and bpf_endian.h official part of libbpf. Ensure they >>>>>> are installed along the other libbpf headers. >>>>>> >>>>>> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> >>>>> >>>>> Can we merge/rearrange 2/6 and 3/6, so they is a git-rename instead of >>>>> many +++ and ---? >>>> >>>> I arranged them that way because of Github sync. We don't sync >>>> selftests/bpf changes to Github, and it causes more churn if commits >>>> have a mix of libbpf and selftests changes. >>>> >>>> I didn't modify bpf_helpers.h/bpf_endian.h between those patches, so >>>> don't worry about reviewing contents ;) >>> >>> I thought we were over this :/ Please merge the patches. >> >> Andrii changed syntax for BPF_CORE_READ(). I guess that is new? > > I meant the battle to not split changes into harder to review, and less > logical form based on what some random, never review upstream script > can or cannot do :) > > I was responding to the "don't worry about reviewing contents" - as you > pointed out git would just generate a move.. Yeah, I got your actual point a few minutes later. Thanks for the clarification. :) Song
