> On Sep 27, 2019, at 12:03 PM, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: > > On 9/27/19 12:44 PM, Song Liu wrote: >> On Thu, Sep 26, 2019 at 6:14 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: >>> >>> make TARGETS=bpf kselftest fails with: >>> >>> Makefile:127: tools/build/Makefile.include: No such file or directory >>> >>> When the bpf tool make is invoked from tools Makefile, srctree is >>> cleared and the current logic check for srctree equals to empty >>> string to determine srctree location from CURDIR. >>> >>> When the build in invoked from selftests/bpf Makefile, the srctree >>> is set to "." and the same logic used for srctree equals to empty is >>> needed to determine srctree. >>> >>> Check building_out_of_srctree undefined as the condition for both >>> cases to fix "make TARGETS=bpf kselftest" build failure. >>> >>> Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> >> The fix looks reasonable. Thanks! >> However, I am still seeing some failure: >> make TARGETS=bpf kselftest >> [...] >> test_verifier.c >> /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/test_stub.o >> /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/libbpf.a >> -lcap -lelf -lrt -lpthread -o >> /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/test_verifier >> make[3]: test_verifier.c: Command not found >> Is this just a problem with my setup? > > You are running into the second bpf failure because of the dependency > on the latest llvm. This is known issue with bpf test and it doesn't > compile on 5.4 and maybe even 5.3 > Thanks for the clarification. Acked-by: Song Liu <songliubraving@xxxxxx>
