On Mon, Sep 16, 2019 at 6:05 AM Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTIONS > was not added until kernel 5.3, so this means that creating XSK sockets > always fails on older kernels. > > Since the option is just used to set the zero-copy flag in the xsk struct, > and that flag is not really used for anything yet, just remove the > getsockopt() call until a proper use for it is introduced. > > Suggested-by: Yonghong Song <yhs@xxxxxx> > Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > --- > v2: > - Remove the call entirely. > > tools/lib/bpf/xsk.c | 11 ----------- > 1 file changed, 11 deletions(-) > Who doesn't like removal of code?.. :) Acked-by: Andrii Nakryiko <andriin@xxxxxx> [...]
