On Wed, Aug 28, 2019 at 04:34:22PM -0700, Jakub Kicinski wrote: > > Greg, Thomas, libbpf is extracted from the kernel sources and > maintained in a clone repo on GitHub for ease of packaging. > > IIUC Alexei's concern is that since we are moving the commits from > the kernel repo to the GitHub one we have to preserve the commits > exactly as they are, otherwise SOB lines lose their power. > > Can you provide some guidance on whether that's a valid concern, > or whether it's perfectly fine to apply a partial patch? Right. That's exactly the concern. Greg, Thomas, could you please put your legal hat on and clarify the following. Say some developer does a patch that modifies include/uapi/linux/bpf.h ..some other kernel code...and tools/include/uapi/linux/bpf.h That tools/include/uapi/linux/bpf.h is used by perf and by libbpf. We have automatic mirror of tools/libbpf into github/libbpf/ so that external projects and can do git submodule of it, can build packages out of it, etc. The question is whether it's ok to split tools/* part out of original commit, keep Author and SOB, create new commit out of it, and automatically push that auto-generated commit into github mirror. So far we've requested all developers to split their patches manually. So that tools/* update is an individual commit that mirror can simply git cherry-pick.
