On Thu, 22 Aug 2019 at 15:26, Hillf Danton <hdanton@xxxxxxxx> wrote: > > > > > > /* Make sure queue is ready before it can be seen by others */ > > > smp_wmb(); > > > > Hehe, who put mb here and for what? > That was from an earlier commit, and it's a barrier paired with the lock-less reading of queues in xsk_mmap. Uhm... not sure I answered your question? Björn > > > >- *queue = q; > > >+ WRITE_ONCE(*queue, q); > > > return 0; > >