On Thu, 15 Aug 2019 22:45:43 -0700 Andrii Nakryiko <andriin@xxxxxx> wrote: > bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper > definitions essential to almost every BPF program. Which makes them > useful not just for selftests. To be able to expose them as part of > libbpf, though, we need them to be dual-licensed as LGPL-2.1 OR > BSD-2-Clause. This patch updates licensing of those two files. I've already ACKed this, and is fine with (LGPL-2.1 OR BSD-2-Clause). I just want to understand, why "BSD-2-Clause" and not "Apache-2.0" ? The original argument was that this needed to be compatible with "Apache-2.0", then why not simply add this in the "OR" ? > Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx> > Acked-by: Hechao Li <hechaol@xxxxxx> > Acked-by: Martin KaFai Lau <kafai@xxxxxx> > Acked-by: Andrey Ignatov <rdna@xxxxxx> > Acked-by: Yonghong Song <yhs@xxxxxx> > Acked-by: Lawrence Brakmo <brakmo@xxxxxx> > Acked-by: Adam Barth <arb@xxxxxx> > Acked-by: Roman Gushchin <guro@xxxxxx> > Acked-by: Josef Bacik <jbacik@xxxxxx> > Acked-by: Joe Stringer <joe@xxxxxxxxxxx> > Acked-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx> > Acked-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx> > Acked-by: David Ahern <dsahern@xxxxxxxxx> > Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> Confirming I acked this. > Acked-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > Acked-by: Lorenz Bauer <lmb@xxxxxxxxxxxxxx> > Acked-by: Adrian Ratiu <adrian.ratiu@xxxxxxxxxxxxx> > Acked-by: Nikita V. Shirokov <tehnerd@xxxxxxxxxxx> > Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx> > Acked-by: Petar Penkov <ppenkov@xxxxxxxxxx> > Acked-by: Teng Qin <palmtenor@xxxxxxxxx> > Cc: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx> > Cc: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > Cc: Michal Rostecki <mrostecki@xxxxxxxxxxxx> > Cc: John Fastabend <john.fastabend@xxxxxxxxx> > Cc: Sargun Dhillon <sargun@xxxxxxxxx> > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > --- > tools/testing/selftests/bpf/bpf_endian.h | 2 +- > tools/testing/selftests/bpf/bpf_helpers.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/bpf_endian.h b/tools/testing/selftests/bpf/bpf_endian.h > index 05f036df8a4c..ff3593b0ae03 100644 > --- a/tools/testing/selftests/bpf/bpf_endian.h > +++ b/tools/testing/selftests/bpf/bpf_endian.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ > #ifndef __BPF_ENDIAN__ > #define __BPF_ENDIAN__ > > diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h > index 8b503ea142f0..6c4930bc6e2e 100644 > --- a/tools/testing/selftests/bpf/bpf_helpers.h > +++ b/tools/testing/selftests/bpf/bpf_helpers.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ > #ifndef __BPF_HELPERS_H > #define __BPF_HELPERS_H > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
