On Thu, Aug 15, 2019 at 11:09 AM Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote: > > On Thu, 15 Aug 2019 11:05:16 -0700, Andrii Nakryiko wrote: > > > > Would it be better to make show_prog(fd) close provided fd instead or > > > > is it used in some other context where FD should live longer (I > > > > haven't checked, sorry)? > > > > > > I think it used to close that's how the bug crept in. Other than the bug > > > it's fine the way it is. > > > > So are you saying that show_prog() should or should not close FD? > > Yup, it we'd have to rename it to indicate it closes the fd, and it's > only called in two places. Not worth the churn. OK, I'm fine with that. Acked-by: Andrii Nakryiko <andriin@xxxxxx>
