Hi, Because the "__printf()" attributes were used only where the functions are implemented, and not in header files, the checks have not been enforced on all the calls to printf()-like functions, and a number of errors slipped in bpftool over time. This set cleans up such errors, and then moves the "__printf()" attributes to header files, so that the checks are performed at all locations. Quentin Monnet (6): tools: bpftool: fix arguments for p_err() in do_event_pipe() tools: bpftool: fix format strings and arguments for jsonw_printf() tools: bpftool: fix argument for p_err() in BTF do_dump() tools: bpftool: fix format string for p_err() in query_flow_dissector() tools: bpftool: fix format string for p_err() in detect_common_prefix() tools: bpftool: move "__printf()" attributes to header file tools/bpf/bpftool/btf.c | 2 +- tools/bpf/bpftool/btf_dumper.c | 8 ++++---- tools/bpf/bpftool/common.c | 4 ++-- tools/bpf/bpftool/json_writer.c | 6 ++---- tools/bpf/bpftool/json_writer.h | 6 ++++-- tools/bpf/bpftool/main.c | 2 +- tools/bpf/bpftool/main.h | 4 ++-- tools/bpf/bpftool/map_perf_ring.c | 4 ++-- tools/bpf/bpftool/net.c | 2 +- tools/include/linux/compiler-gcc.h | 2 ++ 10 files changed, 21 insertions(+), 19 deletions(-) -- 2.17.1