This series adds a "bpftool map count" subcommand to count the number of entries present in a BPF map. This results from a customer request for a tool to count the number of entries in BPF maps used in production (for example, to know how many free entries are left in a given map). The first two commits actually contain some clean-up in preparation for the new subcommand. The third commit adds the new subcommand. Because what data should count as an entry is not entirely clear for all map types, we actually dump several counters, and leave it to the users to interpret the values. Sending as a RFC because I'm looking for feedback on the approach. Is printing several values the good thing to do? Also, note that some map types such as queue/stack maps do not support any type of counting, this would need to be implemented in the kernel I believe. More generally, we have a use case where (hash) maps are under pressure (many additions/deletions from the BPF program), and counting the entries by iterating other the different keys is not at all reliable. Would that make sense to add a new bpf() subcommand to count the entries on the kernel side instead of cycling over the entries in bpftool? If so, we would need to agree on what makes an entry for each kind of map. Note that we are also facing similar issues for purging map from their entries (deleting all entries at once). We can iterate on the keys and delete elements one by one, but this is very inefficient when entries are being added/removed in parallel from the BPF program, and having another dedicated command accessible from the bpf() system call might help here as well. Quentin Monnet (3): tools: bpftool: clean up dump_map_elem() return value tools: bpftool: make comment more explicit for count of dumped entries tools: bpftool: add "bpftool map count" to count entries in map .../bpf/bpftool/Documentation/bpftool-map.rst | 15 +++ tools/bpf/bpftool/bash-completion/bpftool | 4 +- tools/bpf/bpftool/map.c | 110 ++++++++++++++++-- 3 files changed, 119 insertions(+), 10 deletions(-) -- 2.17.1
