On Wed, Aug 7, 2019 at 5:42 PM Yonghong Song <yhs@xxxxxx> wrote: > > On my local machine, I have the following compilation errors: > ===== > In file included from prog_tests/core_reloc.c:3:0: > ./progs/core_reloc_types.h:517:46: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘fancy_char_ptr_t’ > typedef const char * const volatile restrict fancy_char_ptr_t; > ^ > ./progs/core_reloc_types.h:527:2: error: unknown type name ‘fancy_char_ptr_t’ > fancy_char_ptr_t d; > ^ > ===== > > I am using gcc 4.8.5. Later compilers may change their behavior not emitting the > error. Nevertheless, let us fix the issue. "restrict" can be tested > without typedef. > > Fixes: 9654e2ae908e ("selftests/bpf: add CO-RE relocs modifiers/typedef tests") > Cc: Andrii Nakryiko <andriin@xxxxxx> > Signed-off-by: Yonghong Song <yhs@xxxxxx> Applied. Thanks.