On Wed, Jul 24, 2019 at 10:46 PM Andrii Nakryiko <andriin@xxxxxx> wrote: > > Despite a proper NULL-termination after strncpy(..., ..., IFNAMSIZ - 1), > GCC8 still complains about *expected* string truncation: > > xsk.c:330:2: error: 'strncpy' output may be truncated copying 15 bytes > from a string of length 15 [-Werror=stringop-truncation] > strncpy(ifr.ifr_name, xsk->ifname, IFNAMSIZ - 1); > > This patch gets rid of the issue altogether by using memcpy instead. > There is no performance regression, as strncpy will still copy and fill > all of the bytes anyway. > > v1->v2: > - rebase against bpf tree. > > Cc: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > Acked-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > Acked-by: Song Liu <songliubraving@xxxxxx> Applied. Thanks
