On Tue, Jul 16, 2019 at 10:49 AM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Mon, Jul 15, 2019 at 3:22 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: > > > > On 7/12/19 3:56 PM, Ilya Leoshkevich wrote: > > > When directories are used as prerequisites in Makefiles, they can cause > > > a lot of unnecessary rebuilds, because a directory is considered changed > > > whenever a file in this directory is added, removed or modified. > > > > > > If the only thing a target is interested in is the existence of the > > > directory it depends on, which is the case for selftests/bpf, this > > > directory should be specified as an order-only prerequisite: it would > > > still be created in case it does not exist, but it would not trigger a > > > rebuild of a target in case it's considered changed. > > > > > > Signed-off-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > > > > Applied, thanks! > > Hi Ilya, > > this commit breaks map_tests. This change just exposed existing problem with Makefile. Sent out fix. > To reproduce: > rm map_tests/tests.h > make > tests.h will not be regenerated. > Please provide a fix asap. > We cannot ship bpf tree with such failure.
