On Tue, Jul 16, 2019 at 3:56 AM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote: > > Some setups (e.g. virtual machines) might run with hardware perf events > disabled. If this is the case, skip the test_send_signal_nmi test. > > Add a separate test involving a software perf event. This allows testing > the perf event path regardless of hardware perf event support. > > Signed-off-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > --- LGTM! Acked-by: Andrii Nakryiko <andriin@xxxxxx> > > v1->v2: Skip the test instead of using a software event. > Add a separate test with a software event. > > .../selftests/bpf/prog_tests/send_signal.c | 33 ++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/send_signal.c b/tools/testing/selftests/bpf/prog_tests/send_signal.c > index 67cea1686305..54218ee3c004 100644 > --- a/tools/testing/selftests/bpf/prog_tests/send_signal.c > +++ b/tools/testing/selftests/bpf/prog_tests/send_signal.c > @@ -173,6 +173,18 @@ static int test_send_signal_tracepoint(void) > return test_send_signal_common(&attr, BPF_PROG_TYPE_TRACEPOINT, "tracepoint"); > } > [...]
