On 07/11/2019 06:22 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, this patch silences > the following warning: > > kernel/bpf/verifier.c: In function ‘check_return_code’: > kernel/bpf/verifier.c:6106:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG || > ^ > kernel/bpf/verifier.c:6109:2: note: here > case BPF_PROG_TYPE_CGROUP_SKB: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that is much clearer to explicitly add breaks in each case > statement (that actually contains some code), rather than letting > the code to fall through. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Acked-by: Andrii Nakryiko <andriin@xxxxxx> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> Looks good, applied to bpf, thanks.
