On Tue, Jul 9, 2019 at 1:50 AM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: > > On 07/04/2019 02:42 PM, Magnus Karlsson wrote: > > This commit replaces ndo_xsk_async_xmit with ndo_xsk_wakeup. This new > > ndo provides the same functionality as before but with the addition of > > a new flags field that is used to specifiy if Rx, Tx or both should be > > woken up. The previous ndo only woke up Tx, as implied by the > > name. The i40e and ixgbe drivers (which are all the supported ones) > > are updated with this new interface. > > > > This new ndo will be used by the new need_wakeup functionality of XDP > > sockets that need to be able to wake up both Rx and Tx driver > > processing. > > > > Signed-off-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > > --- > > drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++-- > > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 7 ++++--- > > drivers/net/ethernet/intel/i40e/i40e_xsk.h | 2 +- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++-- > > drivers/net/ethernet/intel/ixgbe/ixgbe_txrx_common.h | 2 +- > > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 4 ++-- > > drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c | 2 +- > > drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.h | 2 +- > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- > > include/linux/netdevice.h | 14 ++++++++++++-- > > net/xdp/xdp_umem.c | 3 +-- > > net/xdp/xsk.c | 3 ++- > > 12 files changed, 32 insertions(+), 19 deletions(-) > > Looks good, but given driver changes to support the AF_XDP need_wakeup > feature are quite trivial, is there a reason that you updated mlx5 here > but not for the actual support such that all three in-tree drivers are > supported? It should be easy to add it mlx5 for someone familiar with the driver. I will send Maxim a mail and see if he can contribute a small patch adding the support. Thanks: Magnus > Thanks, > Daniel
