> Am 09.07.2019 um 19:56 schrieb Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>: > > On Tue, Jul 9, 2019 at 8:22 AM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote: >> >> bpf_helpers.h fails to compile on sparc: the code should be checking >> for defined(bpf_target_sparc), but checks simply for bpf_target_sparc. >> >> Signed-off-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> >> --- >> tools/testing/selftests/bpf/bpf_helpers.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h >> index 5f6f9e7aba2a..a8fea087aa90 100644 >> --- a/tools/testing/selftests/bpf/bpf_helpers.h >> +++ b/tools/testing/selftests/bpf/bpf_helpers.h >> @@ -443,7 +443,7 @@ static int (*bpf_skb_adjust_room)(void *ctx, __s32 len_diff, __u32 mode, >> #ifdef bpf_target_powerpc > > While at it, can you please also fix this one? Do you mean #ifdef bpf_target_powerpc? I think it’s correct, because it’s #ifdef, not #if. But I could change it to #if defined() for consistency. Best regards, Ilya
