On Tue, Jul 2, 2019 at 1:43 PM Maxim Mikityanskiy <maximmi@xxxxxxxxxxxx> wrote: > > On 2019-07-02 12:21, Magnus Karlsson wrote: > > This commit replaces ndo_xsk_async_xmit with ndo_xsk_wakeup. This new > > ndo provides the same functionality as before but with the addition of > > a new flags field that is used to specifiy if Rx, Tx or both should be > > woken up. The previous ndo only woke up Tx, as implied by the > > name. The i40e and ixgbe drivers (which are all the supported ones) > > are updated with this new interface. > > This API change will break build of mlx5 - XSK support for mlx5 was merged. Yes, that will definitely break it. But I am glad your support is in :-). Do you have any other comments on this patch set before I make a v3? /Magnus > > This new ndo will be used by the new need_wakeup functionality of XDP > > sockets that need to be able to wake up both Rx and Tx driver > > processing. > > > > Signed-off-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> >