On Mon, Jul 1, 2019 at 1:56 AM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote: > > > Am 28.06.2019 um 22:35 schrieb Song Liu <liu.song.a23@xxxxxxxxx>: > > > > On Thu, Jun 27, 2019 at 2:15 AM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote: > >> > >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > >> index f2dbe2043067..2316fa2d5b3b 100644 > >> --- a/tools/testing/selftests/bpf/Makefile > >> +++ b/tools/testing/selftests/bpf/Makefile > >> @@ -1,5 +1,6 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> > >> +SHELL := /bin/bash > > > > I am not sure whether it is ok to require bash. I don't see such requirements in > > other Makefile's under tools/. > > > > Can we enable some fall back when bash is not present? > > > > Thanks, > > Song > > I think checking for bash presence would unnecessarily complicate > things. What do you think about having separate targets for > clang-generated bitcode? Do we still need clang | llc pipeline with new clang? Could the same be achieved with single clang invocation? That would solve the problem of not detecting pipeline failures. But either way, I think .DELETE_ON_ERROR is worth adding nevertheless. > > Best regards, > Ilya
