On Thu, Jun 27, 2019 at 10:53 PM Andrii Nakryiko <andriin@xxxxxx> wrote:
>
> It's often inconvenient to switch sign of error when passing it into
> libbpf_strerror_r. It's better for it to handle that automatically.
>
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
> Reviewed-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
Acked-by: Song Liu <songliubraving@xxxxxx>
> ---
> tools/lib/bpf/str_error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/str_error.c b/tools/lib/bpf/str_error.c
> index 00e48ac5b806..b8064eedc177 100644
> --- a/tools/lib/bpf/str_error.c
> +++ b/tools/lib/bpf/str_error.c
> @@ -11,7 +11,7 @@
> */
> char *libbpf_strerror_r(int err, char *dst, int len)
> {
> - int ret = strerror_r(err, dst, len);
> + int ret = strerror_r(err < 0 ? -err : err, dst, len);
> if (ret)
> snprintf(dst, len, "ERROR: strerror_r(%d)=%d", err, ret);
> return dst;
> --
> 2.17.1
>
