On Fri, 14 Jun 2019 13:25:05 +0000, Maxim Mikityanskiy wrote: > Imagine you have configured the NIC to have the maximum supported amount > of channels. Then your formula in ethtool.c returns some value. Exactly > the same value should also be returned from libbpf's > xsk_get_max_queues(). It's achieved by applying your formula directly to > max. I'm just trying to limit people inventing their own interpretations of this API. Broadcom for instance does something dumb with current counts I think they return curr.combined = curr.rx, even though there is only curr.combined rings... You will over allocate space for all NICs with return both combined and non-combined counts. But that's not a huge deal, not worth arguing about. Moving on..