On Thu, 13 Jun 2019 11:04:45 +0200, Björn Töpel wrote: > > > + } else { > > > + if (!__dev_xdp_query(dev, bpf_op, query)) > > > + return 0; > > > > This will mask the error if program is installed with different flags. > > > > Hmm, probably missing something, but I fail to see how the error is > being masked? This is to catch the NULL-to-NULL case early. You're right, it shouldn't matter.