On Wed, Jun 12, 2019 at 02:53:35PM -0700, Alexei Starovoitov wrote: > On 6/12/19 2:47 PM, Stanislav Fomichev wrote: > >>>> CFLAGS += -Wall -O2 -I$(APIDIR) -I$(LIBDIR) -I$(BPFDIR) -I$(GENDIR) $(GENFLAGS) -I../../../include \ > >>>> + -I../../../../usr/include/ \ > >>> Why not copy inlude/uapi/asm-generic/socket.h into tools/include > >>> instead? Will that work? > >> Sure. I am ok with copy. I don't think we need to sync very often. > >> Do you know how to do that considering multiple arch's socket.h > >> have been changed in Patch 1? > > No, I don't know how to handle arch specific stuff. I suggest to copy > > asm-generic and have ifdefs in the tests if someone complains:-) It is not very nice but I am ok with that also. It is the only arch I can test ;) > > > >> Is copy better? > > Doesn't ../../../../usr/include provide the same headers we have in > > tools/include/uapi? If you add -I../../../../usr/include, then is there > > a point of having copies under tools/include/uapi? I don't really > > know why we keep the copies under tools/include/uapi rather than including > > ../../../usr/include directly. > > for out-of-src builds ../../../../usr/include/ directory doesn't exist. Is out-of-src build mostly for libbpf? or selftests/bpf also requires out-of-src build?
