On 06/06/2019 02:13 AM, Alexei Starovoitov wrote: > On Wed, Jun 5, 2019 at 5:09 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: >> >>>> tools/bpf/bpftool/cgroup.c | 5 ++++- >>>> tools/include/uapi/linux/bpf.h | 2 ++ >>> Should the bpf.h sync to tools/ be in a separate patch? >> >> I was thinking about it, but concluded for such small change, it's not >> really worth it. If there's a strong opinion, I could do it, but I think >> that 2-liner sync patch just adds noise. > > it's not about the size. It breaks the sync of libbpf. > we should really enforce user vs kernel to be separate patches. Okay, I see. Fair enough, I'll split them in that case. Thanks, Daniel