On Tue, May 28, 2019 at 6:14 PM Andrii Nakryiko <andriin@xxxxxx> wrote:
>
> All of libbpf errors are negative, except this one. Fix it.
>
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
Acked-by: Song Liu <songliubraving@xxxxxx>
> ---
> tools/lib/bpf/libbpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 7abe71ee507a..9c45856e7fd6 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -1221,7 +1221,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj, int flags)
>
> if (!obj->efile.strtabidx || obj->efile.strtabidx >= idx) {
> pr_warning("Corrupted ELF file: index of strtab invalid\n");
> - return LIBBPF_ERRNO__FORMAT;
> + return -LIBBPF_ERRNO__FORMAT;
> }
> if (btf_data) {
> obj->btf = btf__new(btf_data->d_buf, btf_data->d_size);
> --
> 2.17.1
>
