2019-05-28 17:35 UTC-0700 ~ Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> > On Fri, May 24, 2019 at 3:36 AM Quentin Monnet > <quentin.monnet@xxxxxxxxxxxxx> wrote: >> >> libbpf was recently made aware of the log_level attribute for programs, >> used to specify the level of information expected to be dumped by the >> verifier. Function bpf_prog_load_xattr() got support for this log_level >> parameter. >> >> But some applications using libbpf rely on another function to load >> programs, bpf_object__load(), which does accept any parameter for log >> level. Create an API function based on bpf_object__load(), but accepting >> an "attr" object as a parameter. Then add a log_level field to that >> object, so that applications calling the new bpf_object__load_xattr() >> can pick the desired log level. >> >> v3: >> - Rewrite commit log. >> >> v2: >> - We are in a new cycle, bump libbpf extraversion number. >> >> Signed-off-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx> >> Reviewed-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> >> --- >> tools/lib/bpf/Makefile | 2 +- >> tools/lib/bpf/libbpf.c | 20 +++++++++++++++++--- >> tools/lib/bpf/libbpf.h | 6 ++++++ >> tools/lib/bpf/libbpf.map | 5 +++++ >> 4 files changed, 29 insertions(+), 4 deletions(-) > > This commit broke ./test_progs -s > prog_tests/bpf_verif_scale.c no longer passes log_level. > Could you please take a look? > Indeed, I forgot that bpf_load_prog_xattr() would eventually call bpf_object__load_progs() as well, where the log_level is now overwritten. Fix incoming, sorry about that. Quentin
