On Thu, May 23, 2019 at 04:09:30PM -0700, Yonghong Song wrote: > > > On 5/23/19 12:45 PM, Roman Gushchin wrote: > > Add a kselftest to cover bpf auto-detachment functionality. > > The test creates a cgroup, associates some resources with it, > > attaches a couple of bpf programs and deletes the cgroup. > > > > Then it checks that bpf programs are going away in 5 seconds. > > > > Expected output: > > $ ./test_cgroup_attach > > #override:PASS > > #multi:PASS > > #autodetach:PASS > > test_cgroup_attach:PASS > > > > On a kernel without auto-detaching: > > $ ./test_cgroup_attach > > #override:PASS > > #multi:PASS > > #autodetach:FAIL > > test_cgroup_attach:FAIL > > > > Signed-off-by: Roman Gushchin <guro@xxxxxx> > > Looks good to me. It will be good if you can add test_cgroup_attach > to .gitignore to avoid it shows up in `git status`. With that, I don't think it deserves a new version, I'll prepare a separate patch for it. > > Acked-by: Yonghong Song <yhs@xxxxxx> Thank you for the review!
