On 5/21/19 9:09 PM, Andrii Nakryiko wrote: > >> Hit/miss heuristic is not counting index miscompare as a miss. >> Otherwise verifier stats become unstable when experimenting >> with different hash functions. >> >> If insn comparison is done inside states_equal() then >> miss > hit * 3 + 3 heuristic affects 'collisions'. >> The cases where different indices fall into the same bucket. >> And verifier stats fluctuate when hash function or size changes. >> > > Yeah, that make sense. I wonder if curframe comparison has similar > effect, states from different frames seem similar to hash collisions > between different instruction states in that regard. Or they are not? Since curframe is not part of the hash it doesn't have such property.
