On Mon, May 13, 2019 at 10:20:19AM -0700, 'Eric Dumazet' via syzkaller wrote: > On Mon, May 13, 2019 at 10:17 AM Mark Rutland <mark.rutland@xxxxxxx> wrote: > > > > On Mon, May 13, 2019 at 09:38:55AM -0700, 'Eric Dumazet' via syzkaller wrote: > > > Various things in eBPF really require us to disable preemption > > > before running an eBPF program. > > > > Is that true for all eBPF uses? I note that we don't disable preemption > > in the lib/test_bpf.c module, for example. > > > > If it's a general requirement, perhaps it's worth an assertion within > > BPF_PROG_RUN()? > > The assertion is already there :) > > This is how syzbot triggered the report. Ah! :) I also see I'm wrong about test_bpf.c, so sorry for the noise on both counts! Thanks, Mark.