On 04/30/2019 03:21 PM, Michael Ellerman wrote: > Hi Daniel, > > I'm running selftests/bpf/test_tag and it's taking roughly half an hour > to complete, is that expected? > > I don't really grok what the test is doing TBH, but it does appear to be > doing it 5 times :) > > for (i = 0; i < 5; i++) { > do_test(&tests, 2, -1, bpf_gen_imm_prog); > do_test(&tests, 3, fd_map, bpf_gen_map_prog); > } > > Could we make it just do one iteration by default? That would hopefully > reduce the runtime by quite a bit. It could take a parameter to run the > longer version perhaps? On my 2.5 years old laptop it's taking 16 seconds. ;) I'm okay if we reduce the runs and add a long version via cmdline param. It's basically comparing the sha based tag generation from the BPF core with plain AF_ALG from crypto subsys over the same insn sequence to make sure both match fine. Thanks, Daniel