Re: [PATCH v3 bpf-next 4/4] bpftool: fix indendation in bash-completion/bpftool

Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx> · Thu, 25 Apr 2019 20:21:09 +0100

2019-04-25 09:55 UTC-0700 ~ Andrii Nakryiko <andriin@xxxxxx>
Fix misaligned default case branch for `prog dump` sub-command.

Reported-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>
Cc: Yonghong Song <yhs@xxxxxx>
Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>
---
  tools/bpf/bpftool/bash-completion/bpftool | 22 +++++++++++-----------
  1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
index bca91d04ed35..50e402a5a9c8 100644
--- a/tools/bpf/bpftool/bash-completion/bpftool
+++ b/tools/bpf/bpftool/bash-completion/bpftool
@@ -273,17 +273,17 @@ _bpftool()
                                  "$cur" ) )
                              return 0
                              ;;
-                    *)
-                        _bpftool_once_attr 'file'
-                        if _bpftool_search_list 'xlated'; then
-                            COMPREPLY+=( $( compgen -W 'opcodes visual linum' -- \
-                                "$cur" ) )
-                        else
-                            COMPREPLY+=( $( compgen -W 'opcodes linum' -- \
-                                "$cur" ) )
-                        fi
-                        return 0
-                        ;;
+                        *)
+                            _bpftool_once_attr 'file'
+                            if _bpftool_search_list 'xlated'; then
+                                COMPREPLY+=( $( compgen -W 'opcodes visual linum' -- \
+                                    "$cur" ) )
+                            else
+                                COMPREPLY+=( $( compgen -W 'opcodes linum' -- \
+                                    "$cur" ) )
+                            fi
+                            return 0
+                            ;;
                      esac
                      ;;
                  pin)


Thanks for that!
Reviewed-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>






