Re: [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 19, 2019 at 11:47:45AM -0500, robert.mccabe@xxxxxxxxxxxxxxxxxxx wrote:
> From: "McCabe, Robert J" <Robert.McCabe@xxxxxxxxxxxxxxxxxxx>
> 
> The BPF_PROG_LOAD condition for kernel version <= 5.1 is
> 
>    log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
> 
> Signed-off-by: rjmccabe3701 <robert.mccabe@xxxxxxxxxxxxxxxxxxx>
> ---
>  tools/lib/bpf/bpf.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index bc30783d1403..62d67caa7aea 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -92,7 +92,7 @@ struct bpf_load_program_attr {
>  #define MAPS_RELAX_COMPAT	0x01
> 
>  /* Recommend log buffer size */
> -#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
> +#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */

thanks. good catch.
please replace with (UINT32_MAX >> 8)

sending one patch was enough. no need to spam 5 times.




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux