On Thu, Apr 18, 2019 at 05:43:50PM -0700, Stanislav Fomichev wrote: > On 04/18, Alexei Starovoitov wrote: > > On Mon, Apr 15, 2019 at 10:38:00AM -0700, Stanislav Fomichev wrote: > > > Update all users eth_get_headlen to pass network namespace > > > and pass it down to the flow dissector. This commit is a noop > > > until administrator inserts BPF flow dissector program. > > > > > > Cc: Maxim Krasnyansky <maxk@xxxxxxxxxxxxxxxx> > > > Cc: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> > > > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx > > > Cc: Yisen Zhuang <yisen.zhuang@xxxxxxxxxx> > > > Cc: Salil Mehta <salil.mehta@xxxxxxxxxx> > > > Cc: Michael Chan <michael.chan@xxxxxxxxxxxx> > > > Cc: Igor Russkikh <igor.russkikh@xxxxxxxxxxxx> > > > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx> ... > > Also please add C based test for skb-less flow_dissector. > > Current test_flow_dissector.sh doesn't seem to cover it. > It doesn't look like we can exercise skb-less flow dissector from > test_flow_dissector.sh; we need to trigger some driver code, which is > hard when we send the packets on the localhost in > test_flow_dissector.sh. > > To test skb-less dissector I convert BPF_PROG_TEST_RUN to always use skb-less > mode. test_flow_dissector.sh tests skb-mode, prog_tests/flow_dissector.c > tests skb-less mode. I saw that but I'm afraid it's not enough. tun_get_user() is calling it, so it should be possible to test skb-less mode via tun.
