On Thu, 11 Apr 2019, Song Liu wrote:
> On Thu, Apr 11, 2019 at 4:08 PM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote:
> >
> > It was removed in commit 166b5a7f2ca3 ("selftests_bpf: extend
> > test_tc_tunnel for UDP encap") without any explanation.
> >
> > Otherwise I see:
> > progs/test_tc_tunnel.c:160:17: warning: taking address of packed member 'ip' of class or structure
> > 'v4hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
> > set_ipv4_csum(&h_outer.ip);
> > ^~~~~~~~~~
> > 1 warning generated.
> >
> > Cc: Alan Maguire <alan.maguire@xxxxxxxxxx>
> > Cc: Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> > Fixes: 166b5a7f2ca3 ("selftests_bpf: extend test_tc_tunnel for UDP encap")
> > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
>
> Acked-by: Song Liu <songliubraving@xxxxxx>
>
Thanks for fixing this Stanislav!
Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
> > ---
> > tools/testing/selftests/bpf/progs/test_tc_tunnel.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/progs/test_tc_tunnel.c b/tools/testing/selftests/bpf/progs/test_tc_tunnel.c
> > index bcb00d737e95..ab56a6a72b7a 100644
> > --- a/tools/testing/selftests/bpf/progs/test_tc_tunnel.c
> > +++ b/tools/testing/selftests/bpf/progs/test_tc_tunnel.c
> > @@ -157,7 +157,7 @@ static __always_inline int encap_ipv4(struct __sk_buff *skb, __u8 encap_proto,
> > bpf_ntohs(h_outer.ip.tot_len));
> > h_outer.ip.protocol = encap_proto;
> >
> > - set_ipv4_csum(&h_outer.ip);
> > + set_ipv4_csum((void *)&h_outer.ip);
> >
> > /* store new outer network header */
> > if (bpf_skb_store_bytes(skb, ETH_HLEN, &h_outer, olen,
> > --
> > 2.21.0.392.gf8f6787159e-goog
> >
>
