On Thu, Apr 11, 2019 at 4:23 AM Jesper Dangaard Brouer <brouer@xxxxxxxxxx> wrote: > > On Wed, 10 Apr 2019 16:24:37 -0700 > Song Liu <liu.song.a23@xxxxxxxxx> wrote: > > > > /* Feedback loop via tracepoint */ > > > - trace_xdp_cpumap_kthread(rcpu->map_id, processed, drops, sched); > > > + trace_xdp_cpumap_kthread(rcpu->map_id, n, drops, sched); > > > > btw: can we do the tracepoint after local_bh_enable()? > > I would rather not, as my experience is that this result in strange > inaccurate readings, because (as comment below says) this is a > CPU-process-reschedule point. The test tool reads these values and > calculate PPS. Thanks for the explanation! Song > > > > > > > local_bh_enable(); /* resched point, may call do_softirq() */ > > > } > > -- > Best regards, > Jesper Dangaard Brouer > MSc.CS, Principal Kernel Engineer at Red Hat > LinkedIn: http://www.linkedin.com/in/brouer
