On 4/10/19 9:38 PM, Peter Oskolkov wrote: >> >> Notice the "No route to host" errors. > > "No route to host" is OK: there are negative tests, as you requested a > couple of months ago... :), and these tests correctly trigger "no > route to host". > > This output basically tell me that the test passes, both with and without VRF. ok, expected errors like that should be trapped and hidden. I can barely remember what I had for breakfast yesterday, let alone that errors like this are ok months after the initial test submission. Again, I reference what I did for fib_tests as an example of how I think tests should be written: 1 line per test with OK/FAIL at the end of the line, expected errors trapped so a clean runs shows only clean output, verbose option and pause-on-fail option to help diagnose errors when a test breaks. ... >> ### >> >> so netcat is not the right package. 'apt-cache search netcat' shows >> another package, so try it. > > I guess Debian Stretch has a too old version of netcat that does not > support the flags used in the test. I don't have recent Fedora VMs setup to run these tests, but within reason they should work across OS versions (reason to me being widely used OS'es like Debian, Fedora and Ubuntu).
