Re: [PATCH bpf-next 7/7] selftests/bpf: add few verifier scale tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/01/2019 04:17 PM, Daniel Borkmann wrote:
> On 03/30/2019 01:16 AM, Alexei Starovoitov wrote:
>> Add 3 basic tests that stress verifier scalability.
>>
>> test_verif_scale1.c calls non-inlined jhash() function 90 times on
>> different position in the packet.
>> This test simulates network packet parsing.
>> jhash function is ~140 instructions and main program is ~1200 insns.
>>
>> test_verif_scale2.c force inlines jhash() function 90 times.
>> This program is ~15k instructions long.
>>
>> test_verif_scale3.c calls non-inlined jhash() function 90 times on
>> But this time jhash has to process 32-bytes from the packet
>> instead of 14-bytes in tests 1 and 2.
>> jhash function is ~230 insns and main program is ~1200 insns.
>>
>> $ test_progs -s
>> can be used to see verifier stats.
>>
>> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> 
> Do you also have some test cases with actual 1M insns resp. such that hit
> the new complexity limit to check timing / resources it consumes? I think
> these would be good to have as well as part of selftests.

(Another thought on why it would be good to have such tests would be to
see if we would otherwise break long jumps again due to offset truncation
which we had in the core as well as in JITs in the past.)



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux