On Thu, Mar 21, 2019 at 04:00:46PM +0000, Andrey Ignatov wrote:
> luca.boccassi@xxxxxxxxx <luca.boccassi@xxxxxxxxx> [Thu, 2019-03-21 03:26 -0700]:
> > From: Luca Boccassi <bluca@xxxxxxxxxx>
> >
> > Generate a libbpf.pc file at build time so that users can rely
> > on pkg-config to find the library, its CFLAGS and LDFLAGS.
> >
> > Signed-off-by: Luca Boccassi <bluca@xxxxxxxxxx>
...
> > diff --git a/tools/lib/bpf/libbpf.pc.template b/tools/lib/bpf/libbpf.pc.template
> > new file mode 100644
> > index 000000000000..0ecd334c109f
> > --- /dev/null
> > +++ b/tools/lib/bpf/libbpf.pc.template
> > @@ -0,0 +1,11 @@
> > +prefix=@PREFIX@
> > +libdir=@LIBDIR@
> > +includedir=${prefix}/include
> > +
> > +Name: libbpf
> > +URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > +Description: Linux kernel BPF library
github/libbpf/libbpf is a true mirror of kernel's libbpf.
I think if we start shipping libbpf.so from kernel and from github
it will be very confusing to the users...
Which one is the true libbpf?
Also the package should mention the license.
And the license for libbpf is dual lgpl/bsd.
But if we point to the url above it will not make much sense.
I think the packages URL should point to github/libbpf/libbpf
and packaging scripts should be in github only.
Daniel,
what do you think?
