On 03/13/2019 03:15 PM, Björn Töpel wrote: > From: Björn Töpel <bjorn.topel@xxxxxxxxx> > > When the umem is cleaned up, the task that created it might already be > gone. If the task was gone, the xdp_umem_release function did not free > the pages member of struct xdp_umem. > > It turned out that the task lookup was not needed at all; The code was > a left-over when we moved from task accounting to user accounting [1]. > > This patch fixes the memory leak by removing the task lookup logic > completely. > > [1] https://lore.kernel.org/netdev/20180131135356.19134-3-bjorn.topel@xxxxxxxxx/ > > Link: https://lore.kernel.org/netdev/c1cb2ca8-6a14-3980-8672-f3de0bb38dfd@xxxxxxx/ > Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt") > Reported-by: Jiri Slaby <jslaby@xxxxxxx> > Signed-off-by: Björn Töpel <bjorn.topel@xxxxxxxxx> Applied, thanks!
