On 02/28/2019 11:40 PM, Song Liu wrote: > On Thu, Feb 28, 2019 at 10:59 AM Andrii Nakryiko <andriin@xxxxxx> wrote: >> >> Fix few formatting errors. Fix few typos and reflow long descriptive >> comments for more even text fill. >> >> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx> > > I think we should not change the code for formatting, as these changes make > git-blame more difficult. How about we only make changes to comments? Kind of true, though git blame is imho not too useful (unless I'm missing some git magic :)); git log -p has much more historical context to search through. I think these cleanups below are okay, though my worry is that for someone doing backports changes that are scattered like this mainly cause conflicts which then gets painful to resolve. I think we could make it work if they are split and more isolated, e.g. syscall ones could be one commit, another one only touching the big contiguous verifier comment, and so on. Thanks, Daniel
