On Fri, 2024-06-28 at 01:47 +0200, Hauke Mehrtens wrote: > ++#if LINUX_VERSION_IS_GEQ(6,0,0) > + u64_stats_inc(&stats64->rx_packets); > + u64_stats_add(&stats64->rx_bytes, skb->len); > ++#else > ++ stats64->rx_packets++; > ++ stats64->rx_bytes += skb->len; > ++#endif I suspect we _could_ do this with an auto-detect macro? #if ... /* < 5.5 */ #define u64_stats_inc(v) (*v)++ #define u64_stats_add(v, a) (*v)+=(a) #else #define u64_stats_inc(v) \ do { if (__builtin_types_compatible(typeof(v), *u64_stats_t) u64_stats_inc(v); else (*v)++; } while(0) or so? But then it's only one driver here ... johannes