Re: [PATCH] Updating id field in backports genl family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Looking at this again ...

> I see the patch causes compiling error becasue family->family is not
> found when LINUX_VERSION >= 3.13

Yeah, that seems right.

> backports/backport/backport-include/genetlink.h
> struct backport_genl_fmaily is only defined when LINUX_VERSION < 3.13
> And in backports/backport/compat/backport-3.13.c line 127 
> family->id = family->
> it looks like this line has done what the patch want to do. Is the
> comprehension correct?

I don't think so. We call this function - via
__real_bp_extack_genl_register_family() - on copy->family, so we do need
to copy like Aaron said, we just need to make it conditional for kernel
< 3.13 because on 3.13 we don't use this sub-family thing.

I've committed a fix - does that work for both of you? Aaron?

To unsubscribe from this list: send the line "unsubscribe backports" in

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux