Parse error with genl-const.cocci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



I'd like to say thank you for this very useful project.  I am
relatively new to kernel development, so it would be impossible
for me to sort out the "collateral evolutions" and history of the
linux internals without backports.

I am trying to backport the rtl8192cu driver from linux v4.14-rc4
to an Android 5.11 system running linux kernel v3.10.  My
development system is Linux Mint 17.1.  I chose v4.14-rc4 because
that's the latest tag in backports.  My backports repo and
linux-next repo are checked out to v4.14-rc4-1 and v4.14-rc4,

I am getting an error when I try to create a backport package:

backports $ ./ --clean --verbose --git-revision v4.14-rc4 ../linux-next/ ../linux-backport/
Get original source files from git ...
Applying patches from patches to ../linux-backport/ ...
Applying patch 0000-upstream-backport-changes/0005-uapi-compromise/mwifiex.patch
[...snip lots of good patches here...]
Applying SmPL patch 0027-genl-const/genl-const.cocci
Failed to process SmPL patch 0027-genl-const/genl-const.cocci with 1

Getting the output of pycocci:

backports $ ./devel/pycocci -j 1 -v ./patches/0027-genl-const/genl-const.cocci ../linux-backport/ spatch --sp-file ./patches/0027-genl-const/genl-const.cocci --in-place --recursive-includes --relax-include-path --use-coccigrep --timeout 120 --dir ../linux-backport/
Failed to apply changes from genl-const.cocci
Specific log output from change that failed using genl-const.cocci
init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h
meta: parse error:
  File "./patches/0027-genl-const/genl-const.cocci", line 2, column 10, charpos = 13
  around = '__genl_const',
  whole content = attribute __genl_const;

Full log using genl-const.cocci
init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h
meta: parse error:
  File "./patches/0027-genl-const/genl-const.cocci", line 2, column 10, charpos = 13
  around = '__genl_const',
  whole content = attribute __genl_const;
[...snip callstack...]

This is very similar to this problem:
The conclusion of that thread is that the --integrate workflow is
no longer supported.

However, I am not using --integrate, and I am still getting
errors about parsing '__genl_const'.  Is that a bug in the patch
or possibly a regression in spatch?  I've tried v4.14-rc2 also,
but nothing older.

This page has a lot of great example info, and suggested that it
could be a problem with my version of spatch. Specifically, that
I was missing the menhir and libmenhir-ocaml-dev packages when
building Coccinelle and a rebuild should help.

Unfortunately, I still have the same errors after running make
distclean and rebuilding.

I have:
coccinelle $ git describe --tags
coccinelle $ spatch --version
spatch version 1.0.6-00365-gd73c6e6 compiled with OCaml version 4.01.0
Flags passed to the configure script: [none]
OCaml scripting support: yes
Python scripting support: yes
Syntax of regular expresssions: PCRE

I found this patch which describes how older versions can't
handle the __genl_const changes (20150209):

But, I also see commit 748116c8 from shortly after (20150507)
which introduced genl-const.cocci and says only spatch 1.0.0-rc23
is needed.

I feel like I'm close to figuring this out, but would appreciate
any help or pointers.

Thank you,
Remington Furman
To unsubscribe from this list: send the line "unsubscribe backports" in

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux