Re: [PATCH] backports: remove CRYPTO_CCM backport

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-10-13 at 12:31 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> This never actually worked properly as far as I can tell,
> and now it looks like it won't even compile due to the
> real crypto_memneq() backport.
> 
> Just remove it - distro kernels have it enabled and all
> others should just enable it.
> 
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> ---
>  backport/compat/Kconfig     | 11 -------
>  backport/compat/Makefile    |  1 -
>  backport/compat/backports.h | 10 ------
>  backport/compat/main.c      |  9 +-----
>  patches/crypto-ccm.patch    | 78 ---------------------------------
> ------------
>  5 files changed, 1 insertion(+), 108 deletions(-)
>  delete mode 100644 patches/crypto-ccm.patch
> 
> diff --git a/backport/compat/Kconfig b/backport/compat/Kconfig
> index 542cf0cca781..492efbfc7d9f 100644
> --- a/backport/compat/Kconfig
> +++ b/backport/compat/Kconfig
> @@ -102,17 +102,6 @@ config BPAUTO_USERSEL_BUILD_ALL
>  	  It's only really useful for compat testing, so
>  	  you probably shouldn't enable it.
>  
> -config BPAUTO_CRYPTO_CCM
> -	depends on CRYPTO_AEAD
> -	depends on CRYPTO_CTR
> -	bool
> -
> -config BPAUTO_BUILD_CRYPTO_CCM
> -	bool
> -	default n if CRYPTO_CCM
> -	default y if BPAUTO_CRYPTO_CCM
> -	#c-file crypto/ccm.c
> -
>  config BPAUTO_CRYPTO_SKCIPHER
>  	tristate
>  	depends on KERNEL_4_3

Should backports then depend on CRYPTO_CCM? It didn't really work in
the past and I got a few reports of broken backport with old kernels
due to missing CRYPTO_CCM in the kernel config.

--
Luca.
--
To unsubscribe from this list: send the line "unsubscribe backports" in



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux